Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instr(buffer): More temporary metrics around dequeue #4030

Merged
merged 2 commits into from
Sep 13, 2024
Merged

instr(buffer): More temporary metrics around dequeue #4030

merged 2 commits into from
Sep 13, 2024

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Sep 13, 2024 •
edited
Loading

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review September 13, 2024 06:39
@jjbayer jjbayer requested a review from a team as a code owner September 13, 2024 06:39
iambriccardo
iambriccardo reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add one to measure how many times we wait for the back pressure channel?

@jjbayer jjbayer changed the title instr(buffer): More metrics instr(buffer): More temporary metrics around dequeue Sep 13, 2024
@jjbayer jjbayer enabled auto-merge (squash) September 13, 2024 06:47
@jjbayer jjbayer merged commit 5d351d5 into master Sep 13, 2024
24 checks passed
@jjbayer jjbayer deleted the instr/buffer-metrics-inter branch September 13, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjbayer @iambriccardo