fix(buffer): Optimistically initialize stacks as ready #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
approved these changes
Sep 19, 2024
jjbayer
commented
Sep 19, 2024
| relay_statsd::metric!(counter(RelayCounters::BufferEnvelopesReturned) += 1); | ||
| self.push(buffer, envelope).await; | ||
| buffer.mark_ready(&project_key, false); |
There was a problem hiding this comment.
This was a pre-existing bug: Calling mark_ready on an empty stack has no effect, so we should call it after putting back the envelope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new stack is created, the buffer does not know the corresponding project state(s). It previously assumed "not ready", which means it sent a
UpdateStatemessage to the project state on the first envelope.In practice, the vast majority is created when a project state is ready and the stack was previously removed from the priority queue because it was empty. This PR flips the default to "ready", which means that on startup the project cache will return
NotReadyonce.#skip-changelog