Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gocd): Fixing sentry release creation for pops deploy in s4s #4048

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gocd/templates/pipelines/pops.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ local region_pops = {
'us-pop-regional-3',
'us-pop-regional-4',
],
s4s: [],
};

// The purpose of this stage is to let the deployment soak for a while and
Expand Down Expand Up @@ -189,6 +190,7 @@ local deploy_pops_stage(region) =
},
} {
'deploy-primary'+: {
fetch_materials: true,
jobs+: deploy_jobs(
[region] + region_pops[region],
deploy_pop_job,
Expand All @@ -213,6 +215,9 @@ local deployment_stages(region) =
if region == 'us' || region == 'de' then
// The canary stage is only for the US and DE regions
[deploy_canary_pops_stage(region), deploy_pops_stage(region)]
else if region == 's4s' then
// We still want to create a sentry release for s4s
[deploy_pops_stage(region)]
else
[deploy_generic_pops_stage(region)];

Expand Down
Loading