feat(spooler): Implement backpressure in spooler via bounded queues #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Sep 20, 2024
jjbayer
approved these changes
Sep 20, 2024
| @@ -955,6 +960,9 @@ pub struct EnvelopeSpool { | |||
| /// internal page stats. | |||
| #[serde(default = "spool_disk_usage_refresh_frequency_ms")] | |||
| disk_usage_refresh_frequency_ms: u64, | |||
| /// The amount of envelopes that can be put in the bounded buffer. | |||
There was a problem hiding this comment.
Suggested change
| /// The amount of envelopes that can be put in the bounded buffer. | |
| /// The amount of envelopes that the envelope buffer can push to its output queue. |
| @@ -1489,6 +1483,11 @@ impl Service for ProjectCacheService { | |||
| broker.handle_periodic_unspool() | |||
| }) | |||
| } | |||
| Some(message) = envelopes_rx.recv() => { | |||
| metric!(timer(RelayTimers::ProjectCacheTaskDuration), task = "handle_envelope", { | |||
There was a problem hiding this comment.
Could you also log a metric for the current size of the bounded queue somewhere (e.g. in the ticker)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a backpressure mechanism in the spooler which uses a bounded buffer of size
x. The bounded buffer is used exclusively for sending envelopes to the project cache.Closes: https://github.com/getsentry/team-ingest/issues/541
#skip-changelog