Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(gocd): Add service queue alerts to soak time #4054

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gocd/templates/pipelines/pops.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ local soak_time(region) =
DATADOG_API_KEY: '{{SECRET:[devinfra][sentry_datadog_api_key]}}',
DATADOG_APP_KEY: '{{SECRET:[devinfra][sentry_datadog_app_key]}}',
// Datadog monitor IDs for the soak time
DATADOG_MONITOR_IDS: '27804625 22634395',
DATADOG_MONITOR_IDS: '27804625 22634395 154096667 154096672',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This triggers on both s4s and us alerts, which is not great, but I did not want to split the whole block into s4s and us.

// Sentry projects to check for errors <project_id>:<project_slug>:<service>
SENTRY_PROJECTS: if region == 's4s' then '1513938:sentry-for-sentry:relay' else '9:pop-relay:relay-pop 4:relay:relay',
SENTRY_SINGLE_TENANT: if region == 's4s' then 'true' else 'false',
Expand Down Expand Up @@ -84,7 +84,7 @@ local deploy_pop_canary_job(region) =
DATADOG_API_KEY: '{{SECRET:[devinfra][sentry_datadog_api_key]}}',
DATADOG_APP_KEY: '{{SECRET:[devinfra][sentry_datadog_app_key]}}',
// Datadog monitor IDs for the canary deployment
DATADOG_MONITOR_IDS: '27804625 22634395',
DATADOG_MONITOR_IDS: '27804625 22634395 154096667 154096672',
// Sentry projects to check for errors <project_id>:<project_slug>:<service>
SENTRY_PROJECTS: '9:pop-relay:relay-pop 4:relay:relay',
SENTRY_SINGLE_TENANT: 'false',
Expand Down
4 changes: 2 additions & 2 deletions gocd/templates/pipelines/processing.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ local soak_time(region) =
DATADOG_API_KEY: '{{SECRET:[devinfra][sentry_datadog_api_key]}}',
DATADOG_APP_KEY: '{{SECRET:[devinfra][sentry_datadog_app_key]}}',
// Datadog monitor IDs for the soak time
DATADOG_MONITOR_IDS: '14146876',
DATADOG_MONITOR_IDS: '14146876 154096671 154096678',
// Sentry projects to check for errors <project_id>:<project_slug>:<service>
SENTRY_PROJECTS: if region == 's4s' then '1513938:sentry-for-sentry:relay' else '4:relay:relay 9:pop-relay:relay-pop',
SENTRY_SINGLE_TENANT: if region == 's4s' then 'true' else 'false',
Expand Down Expand Up @@ -79,7 +79,7 @@ local deploy_canary(region) =
DATADOG_API_KEY: '{{SECRET:[devinfra][sentry_datadog_api_key]}}',
DATADOG_APP_KEY: '{{SECRET:[devinfra][sentry_datadog_app_key]}}',
// Datadog monitor IDs for the canary deployment
DATADOG_MONITOR_IDS: '14146876',
DATADOG_MONITOR_IDS: '14146876 154096671',
// Sentry projects to check for errors <project_id>:<project_slug>:<service>
SENTRY_PROJECTS: '4:relay:relay 9:pop-relay:relay-pop',
SENTRY_SINGLE_TENANT: 'false',
Expand Down
Loading