Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buffer): Replace spool health check #4055

Merged
merged 9 commits into from
Sep 27, 2024
Merged

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Sep 20, 2024

The spool health check previously sent a message to the project cache, and thus depended on project cache message handling latency. With the new observable envelope buffer, we can check (cached) capacity directly without involving the project cache or awaiting.

Note: For spool V1, this PR now disables the health check completely.

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review September 26, 2024 09:06
@jjbayer jjbayer requested a review from a team as a code owner September 26, 2024 09:06
@jjbayer jjbayer enabled auto-merge (squash) September 26, 2024 12:31
@jjbayer jjbayer merged commit 7419604 into master Sep 27, 2024
23 checks passed
@jjbayer jjbayer deleted the fix/spool-health-check branch September 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants