feat(security): Add API bearer token auth via JWT #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
changed the title
|
What is the plan for generating the JWT, just locally with some sort of management command? |
mdtro
reviewed
Aug 16, 2024
mdtro
reviewed
Aug 16, 2024
jennmueng
force-pushed
the
jenn/api-key
branch
from
60beb61
to
b09bb1b
Compare
corps
reviewed
Aug 26, 2024
corps
reviewed
Aug 26, 2024
corps
reviewed
Aug 26, 2024
corps
reviewed
Aug 27, 2024
corps
reviewed
Aug 27, 2024
jennmueng
force-pushed
the
jenn/api-key
branch
from
21aed40
to
f0b8dda
Compare
corps
reviewed
Aug 27, 2024
src/seer/configuration.py
Outdated
| @@ -74,6 +79,11 @@ def has_sentry_integration(self) -> bool: | |||
| return not self.NO_SENTRY_INTEGRATION | |||
|
|
|||
| def do_validation(self): | |||
| if self.IGNORE_API_AUTH: | |||
There was a problem hiding this comment.
should this be if not self.IGNORE_API_AUTH?
corps
approved these changes
Aug 27, 2024
aayush-se
pushed a commit
that referenced
this pull request
Sep 10, 2024
Mainly for the staging deployment in `ml-ai` Introduces an `ENFORCE_API_AUTH` env variable that will enforce either the rpc secret signing or the bearer token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly for the staging deployment in
ml-aiIntroduces an
ENFORCE_API_AUTHenv variable that will enforce either the rpc secret signing or the bearer token.