feat(autofix): Reproduction in root causes #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
force-pushed
the
jenn/autofix/root-cause-repro
branch
from
e23ac2f
to
8e49488
Compare
roaga
reviewed
Sep 10, 2024
roaga
approved these changes
Sep 10, 2024
Comment on lines
+141
to
+153
| def clean_tool_call_assistant_messages(self, messages: list[Message]) -> list[Message]: | ||
| new_messages = [] | ||
| for message in messages: | ||
| if message.role == "assistant" and message.tool_calls: | ||
| new_messages.append( | ||
| Message(role="assistant", content=message.content, tool_calls=[]) | ||
| ) | ||
| elif message.role == "tool": | ||
| new_messages.append(Message(role="user", content=message.content, tool_calls=[])) | ||
| else: | ||
| new_messages.append(message) | ||
| return new_messages | ||
|
|
There was a problem hiding this comment.
On this I meant not just as a helper function, but if any messages passed into the client for any completion can be cleaned behind-the-scenes to prevent the errors. That way external code doesn't have to choose whether or not to clean.
There was a problem hiding this comment.
I don't think that's a good idea, given that openai can expect a tool call and its response to be used in a specific way for the LLM input. We should only use this workaround sparingly, in this case, only for the formatter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eval results:
(Before is above, after is below)
