Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(autofix): Pass issue summary to autofix, store raw summary output instead of response #1108

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

roaga
Copy link
Member

@roaga roaga commented Sep 3, 2024

This PR includes:

  1. Changing the issue summary storage logic to store the raw output IssueSummary from GPT, rather than the trimmed SummarizeIssueResponse as before. The extra info, such as reason_step_by_step is useful.
  2. Pass the issue summary to Autofix as additional context. (part of (autofix): Make use of more Sentry context #998) Remove pre-processing step on event details as well. Improvement in evals: 0.48/0.52 -> 0.51/0.55
  3. Allow optional issue summary in AutofixRequest to support new eval dataset

@roaga roaga marked this pull request as draft September 3, 2024 19:57
@roaga roaga marked this pull request as ready for review September 4, 2024 04:07
@roaga roaga requested a review from jennmueng September 4, 2024 04:09
Copy link
Member

@jennmueng jennmueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/seer/automation/autofix/steps/coding_step.py Outdated Show resolved Hide resolved
@roaga roaga merged commit 49ffa0e into main Sep 4, 2024
11 checks passed
@roaga roaga deleted the autofix/use-summary branch September 4, 2024 20:34
aayush-se pushed a commit that referenced this pull request Sep 10, 2024
…stead of response (#1108)

This PR includes:

1. Changing the issue summary storage logic to store the raw output
`IssueSummary` from GPT, rather than the trimmed
`SummarizeIssueResponse` as before. The extra info, such as
`reason_step_by_step` is useful.
2. Pass the issue summary to Autofix as additional context. (part of
#998) Remove pre-processing step on event details as well. Improvement
in evals: 0.48/0.52 -> 0.51/0.55
3. Allow optional issue summary in `AutofixRequest` to support new eval
dataset
Copy link

sentry-io bot commented Sep 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValidationError: 1 validation error for IssueSummary app.summarize_issue_endpoint View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants