Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autofix/codegen): File search tools #1134

Merged
merged 3 commits into from
Sep 9, 2024
Merged

feat(autofix/codegen): File search tools #1134

merged 3 commits into from
Sep 9, 2024

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Sep 6, 2024 •
edited
Loading

Adds a file search and a file search wildcard tool to autofix (and soon the other codegen agents)

jennmueng and others added 2 commits September 6, 2024 13:30
@jennmueng @ram-senth
tools
30dfda5 
Co-authored-by: Ram Senthamarai <ram-senth@users.noreply.github.com>
@jennmueng
test file search
c2071b4
@jennmueng jennmueng requested a review from roaga September 6, 2024 20:33
@jennmueng jennmueng marked this pull request as ready for review September 6, 2024 20:33
roaga
roaga reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but did you test how these new tools affect the Autofix eval scores? I've seen in my experience that increasing tool choice can have a big effect on that.

@jennmueng
Copy link
Member Author

Code looks fine, but did you test how these new tools affect the Autofix eval scores? I've seen in my experience that increasing tool choice can have a big effect on that.

Hmm not yet, good call.

@jennmueng jennmueng merged commit 9576dac into main Sep 9, 2024
11 checks passed
@jennmueng jennmueng deleted the jenn/unittest/pt2 branch September 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaga roaga roaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennmueng @roaga