fix(anomaly-detection): Handle illegal padding amount #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ram-senth
reviewed
Sep 6, 2024
| @@ -42,6 +42,8 @@ def get_mp_dist_from_mp( | |||
| mp_dist = normalizer.normalize(mp_dist) | |||
|
|
|||
| if pad_to_len is not None: | |||
| if pad_to_len - len(mp_dist) < 0: | |||
There was a problem hiding this comment.
Minor nit: len(mp_dist) <= pad_to_len would be a little bit more readable?
There was a problem hiding this comment.
I dont think it should be equal since that just means no padding is added
There was a problem hiding this comment.
Yes you are right. So we should raise error if pad_to_len is less than or equal to len(mp_len).
ram-senth
approved these changes
Sep 9, 2024
aayush-se
added a commit
that referenced
this pull request
Sep 13, 2024
- Generated Synthetic timeseries (cyclical, cyclical with anomaly,
noisy, noisy with anomaly) to use for unit and integration tests
- Timeseries generated in`data-analysis` GitHub repo
- Wrote unit tests for the following modules in anomaly_detection:
- Detectors
- `anomaly_detectors.py`
- `mp_config.py`
- `mp_scorers.py`
- `mp_utils.py`
- `normalizers.py`
- `window_size_selctors.py`
- Models
- `converters.py`
- `timeseries_anomalies.py`
- `timeseries.py`
Wrote integration tests for the `store` and `detect` endpoints for
batch, stream, and combo pipelines
**NOTE:** Wanted to submit this PR to start getting some feedback as
there are a lot of changes. As of submitting this PR, the following
unit/integration tests do not work and I wanted to get some feedback:
- `test_detect_anomalies_online` in `test_anomaly_detection.py`: Was
unsure how to handle database changes during integration test
- `test_detect` in `test_anomaly_detectors.py`: was running into shape
errors with the matrix profile
- `test_incorrect_padding` in `test_mp_utils.py`: this one is fixed as
of [this PR](#1136) so needs to be
merged into main to reflect changes
---------
Co-authored-by: sentry-autofix-experimental[bot] <157164994+sentry-autofix-experimental[bot]@users.noreply.github.com>
Co-authored-by: jenn.muengtaweepongsa <jenn.muengtaweepongsa@sentry.io>
Co-authored-by: Rohan Agarwal <47861399+roaga@users.noreply.github.com>
Co-authored-by: Jenn Mueng <30991498+jennmueng@users.noreply.github.com>
Co-authored-by: Rohan Agarwal <rohan.agarwal@sentry.io>
Co-authored-by: Ram Senthamarai <ram-senth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: is there a more graceful way to handle this?