Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dynamic alert thresholds) Force recompilation of Stumpy library during bootup #1140

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ram-senth
Copy link
Member

Use mode preloading mechanism to force numba compilation for Stumpy library

@ram-senth ram-senth force-pushed the anomaly_detection/warmup_stumpy branch from 97ef15c to 53f0558 Compare September 7, 2024 21:21
future call with different values for one or more parameter will still trigger a recompilation.
"""
data = np.arange(10.0)
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this windowsizeselector logic need to be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point, it doesn't have to be. I was experimenting and forgot to remove that.

Copy link
Contributor

@trillville trillville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - how long does this take? do we need to change anything on the ops side WRT bootup logic to accommodate?

@ram-senth ram-senth force-pushed the anomaly_detection/warmup_stumpy branch from 53f0558 to 1efe008 Compare September 9, 2024 17:31
@ram-senth
Copy link
Member Author

ram-senth commented Sep 9, 2024

lgtm - how long does this take? do we need to change anything on the ops side WRT bootup logic to accommodate?

Interestingly, it doesn't take much time actually, less than 100 ms. Seems like it is a function of the size of the time series used in the first call. I have also added seer_bootup_time metric to track the time taken by the bootup process.

@ram-senth ram-senth merged commit a6dce84 into main Sep 9, 2024
11 checks passed
@ram-senth ram-senth deleted the anomaly_detection/warmup_stumpy branch September 9, 2024 18:26
Copy link

sentry-io bot commented Sep 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Exception: Invalid alert id 278014 app.detect_anomalies_endpoint View Issue
  • ‼️ IntegrityError: (psycopg.errors.UniqueViolation) duplicate key value violates unique constraint "dynamic_alert_ti... app.detect_anomalies_endpoint View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants