-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dynamic alert thresholds) Force recompilation of Stumpy library during bootup #1140
Conversation
97ef15c
to
53f0558
Compare
future call with different values for one or more parameter will still trigger a recompilation. | ||
""" | ||
data = np.arange(10.0) | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this windowsizeselector logic need to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good point, it doesn't have to be. I was experimenting and forgot to remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - how long does this take? do we need to change anything on the ops side WRT bootup logic to accommodate?
53f0558
to
1efe008
Compare
Interestingly, it doesn't take much time actually, less than 100 ms. Seems like it is a function of the size of the time series used in the first call. I have also added |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Use mode preloading mechanism to force numba compilation for Stumpy library