Disable signature auth #1148
Merged
Disable signature auth #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corps
commented
Sep 10, 2024
src/seer/json_api.py
Outdated
| # f"Rpcsignature did not match for given url {request.url} and data" | ||
| # ) | ||
| pass | ||
| if auth_header.startswith("Bearer "): |
There was a problem hiding this comment.
Will remove this later once we determine our plan for codecov stuff, but didn't see any point removing it atm.
There was a problem hiding this comment.
we should change the condition with config.IGNORE_API_AUTH too, cuz right now if we merge this into prod it will hit that case and error
ram-senth
approved these changes
Sep 10, 2024
jennmueng
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.