-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to push self hoisting staging docker compose serice #1157
Conversation
RUN pip install --upgrade pip==24.0 | ||
RUN pip install -r requirements.txt --no-cache-dir | ||
|
||
# Copy model files (assuming they are in the 'models' directory) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving these makes rebuilding images faster, since changes to models or the worker files doesn't require reinstalling pip
ARG SEER_VERSION_SHA | ||
ENV SEER_VERSION_SHA ${SEER_VERSION_SHA} | ||
ARG SENTRY_ENVIRONMENT=production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used to adjust the environment flag of sentry sent errors, allowing us to distinguish stuff coming from staging in the same seer project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add SENTRY_ENVIRONMENT to .env which will be different in staging and local dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have to change anything locally. When you want to run a staging environment, the push-staging
pushes this value into the image with staging
set, but for everyone else it is "production". Production is fine because locally we won't all share the same sentry project, only when we're sharing DSNs do we need to differentiate.
Creates a self hoisting docker-compose image and enables command to push that to a target sandbox for staging deployment.