fix(autofix): Handle more tool usage edge cases #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
commented
Mar 3, 2024
| def find_original_snippet( | ||
| snippet: str, file_contents: str, threshold=0.99, verbose=False | ||
| ) -> str | None: | ||
| def find_original_snippet(snippet: str, file_contents: str, threshold=0.9) -> str | None: |
There was a problem hiding this comment.
default threshold value was simply adjusted to match what we were actually calling it with in the tool call.
| @@ -94,15 +84,17 @@ def find_original_snippet( | |||
| if snippet_start is None: | |||
| return None | |||
|
|
|||
| ellipsis_cases = ["... ", "// ...", "# ...", "/* ... */"] | |||
| ellipsis_comment_cases = ["// ...", "# ...", "/* ... */"] | |||
There was a problem hiding this comment.
the ... originally was to avoid matching javascript's rest ...someObject operator but in turn had the side effect of not working for ... in a line
trillville
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes multiple edge cases seen with agent tool use in latest runs:
-> Handled by replacing
\nmatches outside of quotes in the value of json strings...matching didn't work if the...was the only thing in a line as it didn't end with a...as original code looked for.Should also have extensive test cases to test a lot of possible edge cases for this fragile parsing stuff!