Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autofix): Correctly format chained exceptions #915

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Jul 16, 2024

The new exception chaining introduced in #899 caused error messages not to be returned correctly to the agent:

Screenshot 2024-07-17 at 2 07 57 AM

These changes now result in the correct response being sent to the agent:

Screenshot 2024-07-17 at 1 56 14 AM

@jennmueng jennmueng requested review from roaga and a team July 16, 2024 19:09
@jennmueng jennmueng marked this pull request as ready for review July 16, 2024 19:09
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jennmueng jennmueng enabled auto-merge (squash) July 16, 2024 20:01
@jennmueng jennmueng disabled auto-merge July 16, 2024 20:01
@jennmueng jennmueng merged commit 5fd276d into main Jul 16, 2024
4 of 5 checks passed
@jennmueng jennmueng deleted the jenn/autofix/chained-exception-logging branch July 16, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants