ref(agents): Better interface for LLM agents and clients + test coverage #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corps
reviewed
Jul 17, 2024
tests/automation/agent/test_agent.py
Outdated
| return TestAgent(config) | ||
|
|
||
| def test_initialization(self, agent: LlmAgent, config: AgentConfig): | ||
| assert agent.config == config |
There was a problem hiding this comment.
just minor nit, these types of test seem, low value? Like I'm confident this code gets covered by other parts, and there isn't really much logic or assertions here.
corps
reviewed
Jul 17, 2024
|
|
||
|
|
||
| @stub_module.provider | ||
| def provide_stub_gpt_client() -> GptClient: |
corps
approved these changes
Jul 17, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A major refactor of our agents and clients to better strengthen key structural pathways in Autofix & increase test coverage