Skip to content

Commit

Permalink
ci: Run Clippy with default features (#1993)
Browse files Browse the repository at this point in the history
We should run Clippy only with the default features. Our features either do nothing (with_crash_reporting) or disable compilation of code (managed). Therefore, somewhat unintuitively, enabling all features leads to the update and uninstall command code to not be linted, since these modules are excluded with the managed feature. Linting with the default feature set ensures all code is linted.

Partially unblocks #1992
  • Loading branch information
szokeasaurusrex committed Mar 26, 2024
1 parent 05e0b2f commit 63a515d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: cargo fmt --all -- --check

- name: Run Clippy
run: cargo clippy --workspace --all-features --tests -- -D clippy::all
run: cargo clippy --workspace --tests -- -D clippy::all

test:
strategy:
Expand Down

0 comments on commit 63a515d

Please sign in to comment.