feat: Expose downloadBinary function to install binary
#1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Nov 15, 2023
Correct. I didn't change anything except for adding the logger thing. |
Jonir227
reviewed
Dec 20, 2023
| if (process.env.SENTRYCLI_SKIP_DOWNLOAD === '1') { | ||
| logger.log(`Skipping download because SENTRYCLI_SKIP_DOWNLOAD=1 detected.`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
this should return Promise. it makes error on flag 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to be able to install the CLI manually in downstream dependencies in case postinstall scripts did not get executed.