-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to co-location heuristic if sourcemap url appears remote #1871
Fall back to co-location heuristic if sourcemap url appears remote #1871
Conversation
e1909e6
to
50a4008
Compare
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This is still on my todo list. |
...but the stalebot did not remove the label. 🤔 |
I removed "Status: Stale" and added "Status: In Progress." Hopefully StaleBot leaves the PR alone going forward |
@brettdh is this still in progress? |
Hmm, I thought I'd responded to these changes already, sorry. I'll try to push an update today. |
…e a remote path Fixes getsentry#1870.
50a4008
to
93fddd5
Compare
Responded to the comments above and resolved one. Please let me know if more is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
Applies a heuristic to guess that a sourcemap URL is a remote URL path (without scheme and domain):
/
Fixes #1870.