fix(debugIds): Always instantiate global Error class in debugId injection snippet
#2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/fix-inject-snippet-global-error
branch
from
45d0936
to
de9bfaf
Compare
lforst
approved these changes
Aug 27, 2024
This was referenced Sep 18, 2024
This was referenced Oct 1, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to the JavaScript snippet that's injected into user files to set the debugId.
Previously, we'd instantiate
new Errorin the script, which usually implicitly instantiatesglobalThis.Error. However, if users or frameworks would create their ownErrorclass in the very file where the debugId snippet is instantiated,new Errorwould of course take the user-created class rather than the global one. To fix this, this PR now explicitly instantiates theglobalThis.Errorclass.fixes: getsentry/sentry-javascript-bundler-plugins#593