test(debug-files): Batch tests together #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command only batches together the tests that require no extra setup. Some tests require per-test setup (specifically most of the `bundle-jvm` and most of the `upload` tests), so these are kept separate. In the future, it likely makes sense to use `assert_cmd` for tests that require individual setup, and to use `trycmd` for tests which we can batch together.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/batch-tests/debug-files
branch
from
415c286
to
4896faa
Compare
loewenheim
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command only batches together the tests that require no extra setup. Some tests require per-test setup (specifically most of the
bundle-jvmand most of theuploadtests), so these are kept separate.In the future, it likely makes sense to use
assert_cmdfor tests that require individual setup, and to usetrycmdfor tests which we can batch together.