Support configuration arguments via --sentry-define
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
denrase
changed the title
--define--sentry-define
denrase
changed the title
--sentry-define--sentry-define
|
Any new updates on this feature? |
# Conflicts: # CHANGELOG.md
denrase
requested review from
krystofwoldrich,
stefanosiano and
buenaflor
as code owners
|
@eb-so Sorry for the delay. I updated the PR and now it's ready for review. |
No worries, thanks for the update |
buenaflor
reviewed
Mar 11, 2024
LaurentiuSimionescu
approved these changes
Mar 19, 2024
|
@stefanosiano Could you take a look here? 👀 |
|
@buenaflor Could you re-review here to check if everything is as expected? |
buenaflor
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Looks good, just gotta make sure this also works with the new release/dist pr
|
@buenaflor Let's merge the other PR and then update here. |
5 tasks
# Conflicts: # CHANGELOG.md # lib/src/configuration.dart # test/utils/config_writer.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Tried using Dart Environment Declarations, but failed for several reasons:
dart runin a flutter app (integration test app)It seems plugins can use the arguments users pass, so I opted to implement our own declarations using a similar syntax:
With which users can pass any of our supported keys.
💡 Motivation and Context
Closes #81
💚 How did you test it?
📝 Checklist