Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Support Android 15 16kb pages #2254

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 27, 2024

📜 Description

Test if 16KB page sizes can be supported

💡 Motivation and Context

Relates to #2237

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (4d75417) to head (97a9a30).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2254      +/-   ##
==========================================
+ Coverage   88.20%   91.60%   +3.39%     
==========================================
  Files         235       64     -171     
  Lines        8157     2084    -6073     
==========================================
- Hits         7195     1909    -5286     
+ Misses        962      175     -787     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.86 ms 1269.32 ms 27.46 ms
Size 8.38 MiB 9.71 MiB 1.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
64e4616 1242.80 ms 1270.07 ms 27.27 ms
ed2ae08 1222.10 ms 1226.57 ms 4.47 ms
95c69e3 1223.94 ms 1245.29 ms 21.35 ms
7ade5af 1296.24 ms 1297.43 ms 1.18 ms
c328ffc 1236.73 ms 1260.73 ms 24.00 ms
cfa25fc 1251.77 ms 1275.69 ms 23.92 ms
408bdab 1239.63 ms 1257.61 ms 17.98 ms
deaeece 1252.82 ms 1279.04 ms 26.22 ms
84bc635 1252.26 ms 1273.96 ms 21.70 ms
40680d3 1243.22 ms 1257.02 ms 13.80 ms

App size

Revision Plain With Sentry Diff
64e4616 8.28 MiB 9.34 MiB 1.05 MiB
ed2ae08 8.28 MiB 9.34 MiB 1.06 MiB
95c69e3 8.33 MiB 9.64 MiB 1.31 MiB
7ade5af 8.15 MiB 9.15 MiB 1015.93 KiB
c328ffc 8.34 MiB 9.67 MiB 1.33 MiB
cfa25fc 8.32 MiB 9.43 MiB 1.10 MiB
408bdab 8.28 MiB 9.34 MiB 1.06 MiB
deaeece 8.16 MiB 9.17 MiB 1.01 MiB
84bc635 8.33 MiB 9.40 MiB 1.07 MiB
40680d3 8.10 MiB 9.16 MiB 1.07 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant