Add screenshotCacheDuration to FlutterOptions
#2387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
+ Coverage 84.72% 84.75% +0.02%
==========================================
Files 254 79 -175
Lines 9113 2814 -6299
==========================================
- Hits 7721 2385 -5336
+ Misses 1392 429 -963 ☔ View full report in Codecov by Sentry. |
denrase
requested review from
krystofwoldrich,
stefanosiano,
buenaflor and
martinhaintz
as code owners
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 302.70 ms | 342.17 ms | 39.47 ms |
| 0ac1eed | 370.60 ms | 441.54 ms | 70.94 ms |
| 90a08ea | 477.25 ms | 534.10 ms | 56.85 ms |
| 0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
| 061fed2 | 434.11 ms | 506.49 ms | 72.38 ms |
| 4829ad3 | 381.55 ms | 455.45 ms | 73.90 ms |
| 519423f | 357.00 ms | 415.77 ms | 58.77 ms |
| ddc97ad | 331.45 ms | 384.06 ms | 52.61 ms |
| e3ef570 | 389.71 ms | 459.16 ms | 69.45 ms |
| 2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e5b744f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
| 0ac1eed | 6.06 MiB | 7.03 MiB | 990.44 KiB |
| 90a08ea | 6.49 MiB | 7.55 MiB | 1.06 MiB |
| 0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 061fed2 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 4829ad3 | 6.33 MiB | 7.26 MiB | 943.11 KiB |
| 519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
| ddc97ad | 6.16 MiB | 7.14 MiB | 1003.75 KiB |
| e3ef570 | 6.33 MiB | 7.26 MiB | 950.38 KiB |
| 2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d4d0807 | 1246.94 ms | 1260.69 ms | 13.75 ms |
| f9d18f3 | 1240.20 ms | 1242.78 ms | 2.57 ms |
| 04bd9e6 | 1230.78 ms | 1250.71 ms | 19.94 ms |
| 051e97a | 1245.94 ms | 1249.51 ms | 3.57 ms |
| b8562d0 | 1249.92 ms | 1267.56 ms | 17.64 ms |
| affcf07 | 1240.61 ms | 1266.49 ms | 25.88 ms |
| 2e8b1e1 | 1247.45 ms | 1263.67 ms | 16.22 ms |
| 0f067d3 | 1245.71 ms | 1269.59 ms | 23.88 ms |
| f1314d5 | 1246.46 ms | 1270.92 ms | 24.46 ms |
| e239c83 | 1248.40 ms | 1269.28 ms | 20.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d4d0807 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| f9d18f3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 04bd9e6 | 8.33 MiB | 9.61 MiB | 1.27 MiB |
| 051e97a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| b8562d0 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
| affcf07 | 8.38 MiB | 9.70 MiB | 1.33 MiB |
| 2e8b1e1 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 0f067d3 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
| f1314d5 | 8.10 MiB | 9.08 MiB | 1004.30 KiB |
| e239c83 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -74,6 +74,9 @@ | |||
| ); | |||
| ``` | |||
|
|
|||
| - Add `screenshotCacheDuration` to `FlutterOptions` ([#2387](https://github.com/getsentry/sentry-dart/pull/2387)) | |||
There was a problem hiding this comment.
- 🚫 The changelog entry seems to be part of an already released section
## 8.10.1.
Consider moving the entry to the## Unreleasedsection, please.
|
Closing in favour of #2368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Cache screenshots in order to reduce CPU impact when calling the SDK in tight (awaited) loops.
I'm up for discussion which, if any, default value should be used. Not its 100ms, which should amount to about 6 frames if the app runs with 60fps.
dart_devtools_2024-11-04_15_42_52.814.json
dart_devtools_2024-11-04_15_44_21.890.json
💡 Motivation and Context
Relates to #2379
💚 How did you test it?
Sample app.
📝 Checklist
sendDefaultPiiis enabled