-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js-sdk): add script loader to set up Sentry Javascript SDK #2406
Draft
buenaflor
wants to merge
11
commits into
feat/js-sdk-integration
Choose a base branch
from
feat/sentry-script-loader
base: feat/js-sdk-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich,
stefanosiano and
martinhaintz
as code owners
November 12, 2024 16:03
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/js-sdk-integration #2406 +/- ##
===========================================================
+ Coverage 85.06% 85.92% +0.86%
===========================================================
Files 257 84 -173
Lines 9191 2891 -6300
===========================================================
- Hits 7818 2484 -5334
+ Misses 1373 407 -966 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This will be merged into
feat/js-sdk-integration
branch, not main💡 Motivation and Context
PR Nr 1 of JS SDK integration
💚 How did you test it?
Unit test, manual check of html document
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
#skip-changelog