Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-sdk): add script loader to set up Sentry Javascript SDK #2406

Draft
wants to merge 11 commits into
base: feat/js-sdk-integration
Choose a base branch
from

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 12, 2024

📜 Description

This will be merged into feat/js-sdk-integration branch, not main

💡 Motivation and Context

PR Nr 1 of JS SDK integration

💚 How did you test it?

Unit test, manual check of html document

Screenshot 2024-11-12 at 17 02 12

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 59b4ab8

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (dd16d3e) to head (59b4ab8).

Files with missing lines Patch % Lines
...ib/src/web/script_loader/sentry_script_loader.dart 75.00% 3 Missing ⚠️
...tter/lib/src/integrations/web_sdk_integration.dart 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feat/js-sdk-integration    #2406      +/-   ##
===========================================================
+ Coverage                    85.06%   85.92%   +0.86%     
===========================================================
  Files                          257       84     -173     
  Lines                         9191     2891    -6300     
===========================================================
- Hits                          7818     2484    -5334     
+ Misses                        1373      407     -966     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as draft November 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant