consistent return

getsentry · Sep 20, 2023 · 41de0f7 · 41de0f7
1 parent a6d06a8
commit 41de0f7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/components/githubCta.tsx b/src/components/githubCta.tsx
@@ -34,13 +34,16 @@ export function GitHubCTA({sourceInstanceName, relativePath}: GitHubCTAProps) {
  <SmartLink
  to="https://github.com/getsentry/sentry-docs/issues/new/choose"
  onClick={e => {
- if (window.Sentry?.getCurrentHub?.()) {
- // Only Stop event propagation if Sentry SDK is loaded
- // (i.e. feedback is supported), otherwise will send you to github
- e.preventDefault();
- showModal();
- return false;
+ return true;
+ if (!window.Sentry?.getCurrentHub?.()) {
+ return true;
  }
+
+ // Only Stop event propagation if Sentry SDK is loaded
+ // (i.e. feedback is supported), otherwise will send you to github
+ e.preventDefault();
+ showModal();
+ return false;
  }}
  >
  Report a problem