fix(cordova): fix docs around Cordova Perf and Profiling support (#8562)

getsentry · Nov 25, 2023 · c63e60b · c63e60b · vercel · Nov 25, 2023
1 parent 1450e52
commit c63e60b
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 4 deletions.
diff --git a/src/platform-includes/getting-started-primer/javascript.cordova.mdx b/src/platform-includes/getting-started-primer/javascript.cordova.mdx
@@ -18,4 +18,4 @@ Features:
 - On-device symbolication for JavaScript (in `Debug` mode)
 - [Ionic support](/platforms/javascript/guides/cordova/ionic/)
 - Under the hood the SDK relies on our [JavaScript SDK](/platforms/javascript/), which makes all functions available for JavaScript also available in this SDK including:
- - [Performance Monitoring](/product/performance/) to create transactions
+ - [Performance Monitoring](/platforms/javascript/guides/cordova/performance/instrumentation/custom-instrumentation) to create transactions
diff --git a/src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx b/src/platform-includes/performance/configure-sample-rate/javascript.cordova.mdx
@@ -0,0 +1,8 @@
+<SignInNote />
+
+```javascript
+onDeviceReady: function() {
+ var Sentry = cordova.require("sentry-cordova.Sentry");
+ Sentry.init({ dsn: '___PUBLIC_DSN___' });
+}
+```
diff --git a/src/platforms/common/performance/index.mdx b/src/platforms/common/performance/index.mdx
@@ -22,7 +22,6 @@ supported:
  - php
  - node
 notSupported:
- - javascript.cordova
  - native.breakpad
  - native.crashpad
  - native.minidumps
@@ -95,7 +94,7 @@ Learn more about performance monitoring <PlatformLink to="/configuration/options
 
 ## Verify
 
-<PlatformSection supported={["react-native", "java.spring", "java.spring-boot", "android", "javascript", "apple", "dart", "rust"]}>
+<PlatformSection supported={["react-native", "java.spring", "java.spring-boot", "android", "javascript", "apple", "dart", "rust"]} notSupported={["javascript.cordova"]}>
 
 Verify that performance monitoring is working correctly by using our <PlatformLink to="/performance/instrumentation/automatic-instrumentation/">automatic instrumentation</PlatformLink> or by starting and finishing a transaction using <PlatformLink to="/performance/instrumentation/custom-instrumentation/">custom instrumentation</PlatformLink>.
 

diff --git a/src/platforms/common/performance/instrumentation/index.mdx b/src/platforms/common/performance/instrumentation/index.mdx
@@ -3,7 +3,6 @@ title: Instrumentation
 sidebar_order: 20
 description: "Learn how to instrument performance in your app."
 notSupported:
- - javascript.cordova
  - native.breakpad
  - native.crashpad
  - native.minidumps

diff --git a/...rms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx b/...rms/javascript/common/performance/instrumentation/automatic-instrumentation.mdx
@@ -3,6 +3,8 @@ title: Automatic Instrumentation
 sidebar_order: 10
 supported:
  - javascript
+notSupported:
+ - javascript.cordova
 description: "Learn what transactions are captured after tracing is enabled."
 redirect_from:
  - /performance/included-instrumentation

diff --git a/src/platforms/javascript/common/profiling/index.mdx b/src/platforms/javascript/common/profiling/index.mdx
@@ -5,6 +5,7 @@ supported:
  - javascript
 notSupported:
  - javascript.bun
+ - javascript.cordova
 description: "Learn what transactions are captured after tracing is enabled."
 ---