-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix): Add OTEL auto-instrumentation instructions. #10403
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we merge this in, can we update the docs so that we don't have a separate remix v2 section anymore?
We can add a remix v1 section instead given everyone with new projects should be on remix v2.
|
||
app.all("*", createSentryRequestHandler(/* ... */)); | ||
// ... | ||
``` | ||
|
||
### Usage with Vite development mode (only for SDK versions < 7.106.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these docs still apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That version doesn't feel very relevant anymore. Should I delete the section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove it!
1748841
to
7145ae1
Compare
Bundle ReportChanges will decrease total bundle size by 11 bytes ⬇️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a suggestion. Thanks for updating!
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
9def375
to
636624d
Compare
Documents the changes in getsentry/sentry-javascript#12110