Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): Add OTEL auto-instrumentation instructions. #10403

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

onurtemizkan
Copy link
Collaborator

Documents the changes in getsentry/sentry-javascript#12110

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 1:20pm

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After we merge this in, can we update the docs so that we don't have a separate remix v2 section anymore?

We can add a remix v1 section instead given everyone with new projects should be on remix v2.


app.all("*", createSentryRequestHandler(/* ... */));
// ...
```

### Usage with Vite development mode (only for SDK versions < 7.106.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these docs still apply?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That version doesn't feel very relevant anymore. Should I delete the section?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it!

Copy link

codecov bot commented Jun 14, 2024

Bundle Report

Changes will decrease total bundle size by 11 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.55MB 2 bytes ⬇️
sentry-docs-edge-server 479.46kB 3 bytes ⬇️
sentry-docs-client 6.22MB 6 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion. Thanks for updating!

docs/platforms/javascript/guides/remix/manual-setup.mdx Outdated Show resolved Hide resolved
@AbhiPrasad AbhiPrasad merged commit ab8f37a into master Jun 19, 2024
6 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remix-otel-migration branch June 19, 2024 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants