docs(nextjs): Update Next.js GlobalError prop type #10425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 14 bytes ⬇️
|
lforst
reviewed
Jun 18, 2024
| useEffect(() => { | ||
| Sentry.captureException(error); | ||
| }, [error]); | ||
|
|
||
| return ( | ||
| <html> | ||
| <body> | ||
| {/* This is the default Next.js error component but it doesn't allow omitting the statusCode property yet. */} | ||
| <NextError statusCode={undefined as any} /> | ||
| {/* Passing `0` as `statusCode` as the type has to be a number, but we do not get a status code here. */} |
There was a problem hiding this comment.
Suggested change
| {/* Passing `0` as `statusCode` as the type has to be a number, but we do not get a status code here. */} | |
| {/* `NextError` is the default Next.js error page component. Its type | |
| definition requires a `statusCode` prop, however, since the App Router | |
| does not expose status codes for errors, we simply pass 0 to render a | |
| generic error message.*/} |
I would put the same text in the wizard PR.
lforst
approved these changes
Jun 18, 2024
vivianyentran
approved these changes
Jun 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Updates the Next.js snippet to not use type casting anymore
related to getsentry/sentry-wizard#592
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: