Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): removes fid note and update webvitals intro to clarify field data #10437

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

  • Removes the FID deprecation note, since it's been over 90 days and no longer needed
  • Updates the web vitals intro to clarify that webvitals data come from real user traffic

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 9:52pm

@edwardgou-sentry edwardgou-sentry requested a review from a team June 18, 2024 21:17
Copy link

codecov bot commented Jun 18, 2024

Bundle Report

Changes will decrease total bundle size by 22 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.55MB 15 bytes ⬇️
sentry-docs-edge-server 478.98kB 3 bytes ⬇️
sentry-docs-client 6.21MB 4 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

docs/product/insights/web-vitals/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
@edwardgou-sentry edwardgou-sentry merged commit 8c3fd24 into master Jun 19, 2024
6 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/webvitals-real-user-clarification branch June 19, 2024 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants