Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve Nx CLI docs #10632

Merged
merged 1 commit into from
Jul 22, 2024
Merged

docs: improve Nx CLI docs #10632

merged 1 commit into from
Jul 22, 2024

Conversation

meeroslav
Copy link
Contributor

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 10, 2024

@meeroslav is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:14am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 9:14am

@AbhiPrasad
Copy link
Member

Hey @meeroslav thanks for the PR.

I think we intended these docs to only be used with Angular use cases, hence the title being like that. @Lms24 thoughts on changing this?

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meeroslav 👋

Thanks for opening the PR! I think changing this is fine and calls things by their proper name. As Abhi said, I believe my thought process was to signal that this guide is only meant for Angular. However, we're showing this only in Angular anyway so we're good.

@Lms24
Copy link
Member

Lms24 commented Jul 18, 2024

@meeroslav would you mind rebasing the PR to the latest commit on master? We had some CI changes in docs last week and I can't merge the PR because a job that no longer exists is marked as required.

@Lms24
Copy link
Member

Lms24 commented Jul 22, 2024

heads-up: I rebased the branch to get rid of the pending CI job. Should get merged soon!

@Lms24 Lms24 merged commit 636bf57 into getsentry:master Jul 22, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants