fix(javascript): Add entry to migration guide about forcing a sampling decision #10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
andreiborza
reviewed
Jul 18, 2024
| if (samplingContext.op === 'function.myFunction') { | ||
| return 1; | ||
| } | ||
| return 0.1; |
There was a problem hiding this comment.
The text above talks about 1 or 0, but there's a value in-between used here. Is that on purpose? I'd probably rewrite the paragraph above if so.
There was a problem hiding this comment.
I added an example for a positive (1) and negative (0) decision, as well as a comment to show that the 0.1 is used as a default sample rate
Lms24
force-pushed
the
lms/fix-js-force-sampling-decision
branch
from
85d630c
to
bc496ec
Compare
andreiborza
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our migration guide didn't mention the removal of
sampled: booleanat all previously. This PR adds an entry how to migrate forcing a sampling decision.Since we already mention
tracesSamplerin the docs and how to return a definitely positive sampling decision from it, I think we don't need an extra "Forcing Sampling Decision" guide in the regular docs.