Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(changelog): Duplicate changelog into workspace package #10818

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 24, 2024

This is the first step of separating the changelog from the docs.

This PR simply duplicates the changelog with all of its dependencies into a workspace package, so that it is completely separated from the logic of the docs.

Ref #10819

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:24pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 2:24pm

Copy link

codecov bot commented Jul 24, 2024

Bundle Report

Changes will increase total bundle size by 3.44kB ⬆️

Bundle name Size Change
sentry-docs-server 9.54MB 3.45kB ⬆️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️

package.json Outdated
Comment on lines 14 to 16
"workspaces": [
"./packages/*"
],
Copy link
Member

@chargome chargome Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: For our target architecture we could think of moving changelog, user-docs and dev-docs to ./apps/* and all shared code (UI, tsconfig, eslint, tailwind,...) to ./packages/*

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@lforst lforst merged commit 22dadd1 into master Jul 24, 2024
10 checks passed
@lforst lforst deleted the lforst-extract-changelog branch July 24, 2024 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants