Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom to Span metrics updates #10841

Closed
wants to merge 6 commits into from
Closed

Custom to Span metrics updates #10841

wants to merge 6 commits into from

Conversation

ale-cota
Copy link
Contributor

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 11:15am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 11:15am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 26, 2024 11:15am

Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.54MB 6 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Overall, I think transitioning from "metric types" to "aggregation" makes a ton of sense. Just remember that we'll need to update this wording in all the SDK docs as well!

If you're not sure where to start, here are a few examples of how you can configure spans in order to extract span metrics.

<Alert title="Note" level="info">
Keep in mind that metrics need to configured in the UI before they can be seen in the Metrics Explorer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Keep in mind that metrics need to configured in the UI before they can be seen in the Metrics Explorer.
Keep in mind that metrics need to be configured in the UI before they can be seen in the Metrics Explorer.


<Alert title="Note" level="info">
Keep in mind that metrics need to configured in the UI before they can be seen in the Metrics Explorer.
Go to [Set Up and Configure](https://develop.sentry.dev/product/explore/metrics/metrics-set-up/) to see how metrics can be configured in the UI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this link takes me to a "page not found"

@getsantry
Copy link
Contributor

getsantry bot commented Aug 23, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Aug 23, 2024
@getsantry getsantry bot closed this Aug 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants