Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog): Remove /changelog basepath #10842

Merged
merged 2 commits into from
Jul 25, 2024
Merged

feat(changelog): Remove /changelog basepath #10842

merged 2 commits into from
Jul 25, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Jul 25, 2024

The base path will be very confusing and also technically limiting in the future because it is hosted on changelog.sentry.io. Let's just host the changelog on / and remap stuff to sentry.io/changelog via nginx when changelog.sentry.io is accessed.

  • Remove base path
  • Add assets back and fix their locations by using relative paths rather than absolute pointers to the docs (tested the og images and they work)
  • Use Image component for images

The base path will be very confusing and also technically limiting in the future because it is hosted on `changelog.sentry.io`. Let's just host the changelog on `/` and remap stuff to `sentry.io/changelog` via nginx when `changelog.sentry.io` is accessed.

- Remove base path
- Add assets back and fix their locations by using relative paths rather than absolute pointers to the docs
- Use Image component for images
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:26am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:26am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:26am

Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.54MB 6 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems reasonable!

@lforst lforst merged commit 4e5cd81 into master Jul 25, 2024
10 checks passed
@lforst lforst deleted the lforst-fix-hero branch July 25, 2024 10:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants