Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct regional ingest domain for ORG_INGEST_DOMAIN #10845

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

oioki
Copy link
Member

@oioki oioki commented Jul 25, 2024

DESCRIBE YOUR PR

When selecting a project in the EU, the DSN selector on certain code blocks (for example, Security Policy Reporting) suggests to use the US's oXXX.ingest.sentry.io domain, what is wrong:
image
This PR fixes it by using a correct regional host for the ORG_INGEST_DOMAIN.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@oioki oioki requested a review from smeubank July 25, 2024 10:47
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 11:04am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 11:04am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 11:04am

Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will increase total bundle size by 22 bytes ⬆️

Bundle name Size Change
sentry-docs-server 9.54MB 3 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️
sentry-docs-client 8.18MB 28 bytes ⬆️

@oioki oioki merged commit 678962c into master Jul 31, 2024
10 checks passed
@oioki oioki deleted the fix/correct-regional-ingest-domains branch July 31, 2024 11:39
lforst pushed a commit that referenced this pull request Aug 2, 2024
* fix: use correct regional ingest domain for ORG_INGEST_DOMAIN

* [getsentry/action-github-commit] Auto commit

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants