Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php cron setup documentation #10849

Closed
wants to merge 1 commit into from

Conversation

fsalmen-nx
Copy link

Add a missing ,

DESCRIBE YOUR PR

The cron documentation for php has a missing comma

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 25, 2024

@fsalmen-nx is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@getsantry getsantry bot added the Stale label Aug 16, 2024
@fsalmen-nx
Copy link
Author

the "bug" is still relevant.

@fsalmen-nx
Copy link
Author

@cleptric could you have a look please? Thanks.

@cleptric cleptric enabled auto-merge (squash) August 22, 2024 08:05
@cleptric cleptric disabled auto-merge August 22, 2024 08:05
@getsentry getsentry deleted a comment from getsantry bot Aug 22, 2024
@cleptric cleptric removed the Stale label Aug 22, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 13, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 13, 2024
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 0:45am
sentry-docs ❌ Failed (Inspect) Sep 13, 2024 0:45am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:45am

@chargome
Copy link
Member

@fsalmen-nx sorry we missed this – the build seems to fail now, would you mind doing a rebase?

@cleptric cleptric mentioned this pull request Sep 13, 2024
@cleptric
Copy link
Member

Moved to #11358

@cleptric cleptric closed this Sep 13, 2024
auto-merge was automatically disabled September 13, 2024 14:21

Pull request was closed

@fsalmen-nx fsalmen-nx deleted the patch-1 branch September 16, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants