Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Profiling support on Flutter #10869

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Clarify Profiling support on Flutter #10869

merged 5 commits into from
Jul 29, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jul 26, 2024 •
edited
Loading

DESCRIBE YOUR PR

Resolves getsentry/sentry-dart#2197

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:26am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:26am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 10:26am

@codecov Codecov
Copy link

codecov bot commented Jul 26, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.54MB 6 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️

@buenaflor buenaflor marked this pull request as ready for review July 26, 2024 11:20
@buenaflor buenaflor changed the title [draft] Clarify Profiling support on Flutter Clarify Profiling support on Flutter Jul 26, 2024
kahest
kahest approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small suggestion, otherwise LGTM

@buenaflor @kahest
Update docs/platforms/flutter/profiling/index.mdx
f0bb1b4 
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
@buenaflor buenaflor enabled auto-merge (squash) July 29, 2024 10:11
@buenaflor buenaflor merged commit 06a8eaa into master Jul 29, 2024
9 checks passed
@buenaflor buenaflor deleted the buenaflor-patch-1 branch July 29, 2024 10:26
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kahest kahest kahest approved these changes

@vivianyentran vivianyentran Awaiting requested review from vivianyentran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling docs: clarify platform support
2 participants
@buenaflor @kahest