-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add more detailed OTEL docs #10872
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 38.2kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's really good!
We have just created a few 404s with this change, but that means the linter works fine ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/required-instrumentation.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some rewording suggestions. Otherwise this looks good to me!
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/opentelemetry/custom-setup.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rewording. It's more clear to me now.
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
a86ebe7
to
d636d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for making these updates! I think the flow is much easier to digest. I love the split into "using an existing setup" vs "using an API" <3
This PR extracts the OTEL docs for node out, which used to be nested under "Set Up Tracing > Instrumentation > OpenTelemetry Support", and put it on the top level (TBD - is there a better place for this?)
In addition, it splits this out into dedicated pages explaining how to do different things.
The following docs already existed, and are now split out:
I also added two more:
For discussion