Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated backend tutorial #10875

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

antonpirker
Copy link
Member

Brought the Backend tutorial up to date to the new SDK api.

I also updated the demo repo that goes along with the turial: https://github.com/sentry-tutorials/backend-monitoring

(But I have no permissions yet to push to that repo, so the branch is only on my machine, will update with a link to the PR as soon as I have the permissions)

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:21pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 1:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 29, 2024 1:21pm

Copy link

codecov bot commented Jul 26, 2024

Bundle Report

Changes will decrease total bundle size by 273 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.54MB 264 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking a look at this and making updates! I've added a few more content updates. Excited to get this refreshed! And yes, we should definitely add a link to this in the Django SDK.


```bash
brew install python3
brew install python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
brew install python
brew install python

Do you think we should add a tab here for non Mac or Linux users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a good idea, but on other system it is more than one line and there are tons of ways to install on linux. We could link to this (or something similar) https://python.land/installing-python

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@antonpirker
Copy link
Member Author

I guess we can just merge this now and for the improvements to "how to install python" make a separate pr.

@antonpirker antonpirker merged commit 16dfdc5 into master Jul 29, 2024
9 checks passed
@antonpirker antonpirker deleted the antonpirker/backend-tutorial-django branch July 29, 2024 13:26
@antonpirker
Copy link
Member Author

FYI: updated the sample repo too: https://github.com/sentry-tutorials/backend-monitoring @lizokm

@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants