Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations) Add docs for LitestarIntegration #10880

Conversation

KellyWalker
Copy link
Contributor

@KellyWalker KellyWalker commented Jul 26, 2024

DESCRIBE YOUR PR

Add docs for LitestarIntegration

This PR adds docs for the LitestarIntegration added in this sentry-python PR.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 26, 2024

@KellyWalker is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:06pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:06pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:06pm

@sentrivana
Copy link
Contributor

sentrivana commented Aug 2, 2024

@KellyWalker Are you planning on making any changes to this PR or is it ready for review? The current diff already looks good to me.

If this is ready, I'll make sure this also gets looked at by our docs team and will prepare for having it ready to be merged once an SDK release with the Litestar integration is out.

@KellyWalker
Copy link
Contributor Author

It is ready. I just was not sure it should be taken out of draft form before the code changes went in. But I guess y'all can manage all of that in terms of timing, etc. so I will go ahead and mark it ready for review.

@KellyWalker KellyWalker marked this pull request as ready for review August 2, 2024 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants