Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ngrok): Move Ngrok Docs to Centralized Place #11214

Merged
merged 10 commits into from
Sep 16, 2024
Merged

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented Sep 3, 2024

Currently our Ngrok docs exist in Notion, in multiple dev doc pages which makes setting things up really difficult. We should have 1 authoritative source for setting up ngrok.

Here i moved and slightly update the ngrok instructions that existed in development-server to its own page.

after this, i will move the ngrok instructions for split silo there as well (with improvements to the setup) and fix all the links so we have 1 central place to setup ngrok. 🙌🏽

Edit: Photo is Outdated, please take a look at the actual markdown.
image

@iamrajjoshi iamrajjoshi requested review from a team September 3, 2024 23:39
@iamrajjoshi iamrajjoshi self-assigned this Sep 3, 2024
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:44pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 8:44pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 8:44pm


## Ngrok in `monolith` mode

The following are the steps will setup ngrok for integrations in `monolith` mode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording on this is a bit funny. Also, I'm not sure we need to mention monolith mode until we update the docs with silo'd ngrok instructions.

@iamrajjoshi iamrajjoshi enabled auto-merge (squash) September 16, 2024 20:44
@iamrajjoshi iamrajjoshi merged commit 4ad2852 into master Sep 16, 2024
9 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/ngrok branch September 16, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants