Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framework-features-prio #11237

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

framework-features-prio #11237

wants to merge 22 commits into from

Conversation

smeubank
Copy link
Member

@smeubank smeubank commented Sep 5, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 7:37pm
sentry-docs 🛑 Canceled (Inspect) Sep 16, 2024 7:37pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 7:37pm

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 678 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server 7.44MB 687 bytes ⬆️
sentry-docs-edge-server 254.5kB 3 bytes ⬇️
sentry-docs-client 6.39MB 6 bytes ⬇️

@smeubank
Add vue to nuxt, fix ordering for react and vue
1b04a71 
Main content changes, are that for Nuxt state that vue-router is auto-insturmented

should confirm, the remaining vue features are correct for nuxt

shound confirm, if the react features are relevant to add for Next and Remix. If yes should we simply link or past over as well
@smeubank
Copy link
Member Author

smeubank commented Sep 5, 2024

Main content changes, are that for Nuxt state that vue-router is auto-insturmented

should confirm, the remaining vue features are correct for nuxt

shound confirm, if the react features are relevant to add for Next and Remix. If yes should we simply link or past over as well

@s1gr1d and @AbhiPrasad to confirm points around vue and react for other dependent frameworks.

@smeubank smeubank marked this pull request as ready for review September 5, 2024 09:03
s1gr1d
s1gr1d requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

docs/platforms/javascript/guides/nuxt/features/multiple-apps.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/vue-router.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/vue-router.mdx Outdated Show resolved Hide resolved
@smeubank @s1gr1d
Update docs/platforms/javascript/guides/nuxt/features/vue-router.mdx
11abaca 
Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
@smeubank smeubank requested a review from s1gr1d September 9, 2024 10:15
lizokm
lizokm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for adding this! I just have a few small suggestions.

docs/platforms/javascript/guides/nuxt/config.yml Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/component-tracking.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/component-tracking.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/component-tracking.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/component-tracking.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/component-tracking.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/nuxt/features/vue-router.mdx Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/vue/config.yml Outdated Show resolved Hide resolved
docs/platforms/javascript/guides/react/config.yml Outdated Show resolved Hide resolved
smeubank and others added 15 commits September 16, 2024 21:03
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/vue-router.mdx
7e1499c 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
9dea95f 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/index.mdx
0a75417 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
749235d 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
ec74cca 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
9df4071 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
25ff71a 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/config.yml
793f122 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
9289309 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
cb7d66b 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
b67c0e9 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
ad807ef 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/react/config.yml
476a05f 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/vue/config.yml
762f030 
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank @lizokm
Update docs/platforms/javascript/guides/nuxt/features/component-track…
b93590d 
…ing.mdx

Co-authored-by: Liza Mock <liza.mock@sentry.io>
@smeubank
Copy link
Member Author

shound confirm, if the react features are relevant to add for Next and Remix. If yes should we simply link or past over as well

@AbhiPrasad to confirm points about react for other dependent frameworks.

@AbhiPrasad
Copy link
Member

shound confirm, if the react features are relevant to add for Next and Remix. If yes should we simply link or past over as well

yes they are because those meta framework SDKs simply wrap the react sdk, we should def copy them over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizokm lizokm lizokm approved these changes

@s1gr1d s1gr1d s1gr1d approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smeubank @AbhiPrasad @lizokm @s1gr1d