Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integrations page for Go #11360

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Add Integrations page for Go #11360

merged 5 commits into from
Nov 6, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Sep 13, 2024

Resolves #6229

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Oct 14, 2024 5:14pm
sentry-docs 🛑 Canceled (Inspect) Oct 14, 2024 5:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:14pm

@ribice ribice changed the title add Integrations page for Go Add Integrations page for Go Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will increase total bundle size by 171 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 180 bytes (0.0%) ⬆️
sentry-docs-edge-server-array-push 257.01kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes (-0.0%) ⬇️

@ribice
Copy link
Collaborator Author

ribice commented Oct 6, 2024

Don't close this

@getsentry getsentry deleted a comment from getsantry bot Oct 6, 2024
@cleptric
Copy link
Member

cleptric commented Oct 6, 2024

@ribice you can add the WIP label, with it, it will stay open. Merging this next week.

@cleptric cleptric added the wip label Oct 6, 2024
Comment on lines 13 to 21
```go
sentry.Init(sentry.ClientOptions{
Dsn: "___PUBLIC_DSN___",
Integrations: func(i []Integration) []Integration {
return []Integration{}
},
}
)
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

image

docs/platforms/go/common/integrations/index.mdx Outdated Show resolved Hide resolved
docs/platforms/go/common/integrations/index.mdx Outdated Show resolved Hide resolved
docs/platforms/go/common/integrations/index.mdx Outdated Show resolved Hide resolved
Comment on lines +51 to +64
```go
sentry.Init(sentry.ClientOptions{
Integrations: func(integrations []sentry.Integration) []sentry.Integration {
var filteredIntegrations []sentry.Integration
for _, integration := range integrations {
if integration.Name() == "ContextifyFrames" {
continue
}
filteredIntegrations = append(filteredIntegrations, integration)
}
return filteredIntegrations
},
})
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not sure how this is off? Running it locally it looks like this:

image

ribice and others added 3 commits October 14, 2024 18:39
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
@cleptric cleptric merged commit 0d1d66d into master Nov 6, 2024
10 of 11 checks passed
@cleptric cleptric deleted the go-integration-docs branch November 6, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go SDK] Add integrations docs
2 participants