Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Add documentation for Sentry's ErrorHandler #11361

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 13, 2024

builds on top of #11356

This PR adds a new "Angular Features" sub page for the Angular SDK's ErrorHandler. Previously, the config options and some edge cases around the handler were undocumented and users had to ask for clarifications in GitHub and Discord.

The new page now explains

  • what the error handler does / why it's necessary
  • a couple of options (omitted the old reportDialog options in favour of User Feedback)
  • how to handle multiple error handlers

ref getsentry/sentry-javascript#13636

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 9:08am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 9:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 9:08am

@Lms24 Lms24 changed the base branch from master to lms/ref-angular-app-config-setup September 13, 2024 14:58
@Lms24 Lms24 self-assigned this Sep 13, 2024
@Lms24 Lms24 requested review from a team, lforst and chargome and removed request for a team September 13, 2024 15:01
Copy link

codecov bot commented Sep 13, 2024

Bundle Report

Changes will increase total bundle size by 231 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 240 bytes ⬆️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, this looks great!

Lms24 and others added 2 commits September 17, 2024 10:52
Co-authored-by: Liza Mock <liza.mock@sentry.io>
@Lms24 Lms24 force-pushed the lms/feat-angular-errorhandler-doc branch from 7fc5618 to 005ce9a Compare September 17, 2024 08:52
@Lms24 Lms24 enabled auto-merge (squash) September 17, 2024 08:53
@Lms24 Lms24 merged commit db5e0e2 into master Sep 17, 2024
10 checks passed
@Lms24 Lms24 deleted the lms/feat-angular-errorhandler-doc branch September 17, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants