Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Automatically scroll to search hits on same page #11700

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

chargome
Copy link
Member

This pr checks if a search result is on the current page and if so, automatically scrolls the result into the view.

related to #11699

@chargome chargome self-assigned this Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:29pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:29pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 3:29pm

Copy link

codecov bot commented Oct 31, 2024

Bundle Report

Changes will increase total bundle size by 928.25kB (6.56%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
sentry-docs-server-cjs 8.31MB 925.91kB (12.54%) ⬆️⚠️
sentry-docs-edge-server-array-push 333.11kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 2.35kB (0.04%) ⬆️

Copy link
Collaborator

@a-hariti a-hariti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chargome chargome merged commit 5af5d29 into master Oct 31, 2024
13 checks passed
@chargome chargome deleted the cg/handle-same-page-results branch October 31, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants