Develop sdks #11701
Merged
Develop sdks #11701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 714 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
chargome
approved these changes
Oct 31, 2024
| @@ -68,7 +72,7 @@ | |||
| hgroup h2 { | |||
| font-weight: 300; | |||
| font-size: 1.3rem; | |||
| color: var(--foreground-secondary); | |||
| color: var(--desatPurple2); | |||
There was a problem hiding this comment.
was there a special reason for this?
There was a problem hiding this comment.
Yes, it was never done by our design team, and I think the grey that we had before simply was off. Personally, I think it looks much cleaner now
before
after
what do you think?
There was a problem hiding this comment.
I think the color in light mode is a bit strong but that's fine 👍
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.