-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 5 custom canonical tags based on SEO agency recs #11727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Apparently there is a 404 introduced with this pr which I find weird since you did not change any links – could you still have a look? There is a github action pointing you to the correct page in this pr
I faced the same on another PR @charliemday probably a bug, but I didn't get why it's happening as the url works when I click on it locally 🤔 |
This one's a bit of a mystery to me, all I did here was update some frontMatter data on a few markdown files, I double-checked the syntax, I'm not sure why it would be throwing a 404 on |
@coolguyzone this was fixed in #11742, just rebase your pr on master |
8bed6d5
to
3fc30f9
Compare
Ah, thanks @chargome |
DESCRIBE YOUR PR
See the unchecked rows of https://docs.google.com/spreadsheets/d/1_V8fwvomASiJgXSD4LusD9JrOLZjIG_iCUnvXK3eF2o/edit?usp=sharing for the request.
To verify:
visit: https://sentry-docs-git-more-canonicals.sentry.dev/platforms/javascript/guides/cordova/data-management/sensitive-data/
Inspect and you will see that the canonical tag points to: https://docs.sentry.io/platforms/javascript/guides/koa/data-management/sensitive-data/ as referenced in the spreadsheet.
All five of these link will follow the same behavior.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES