Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 custom canonical tags based on SEO agency recs #11727

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

coolguyzone
Copy link
Collaborator

@coolguyzone coolguyzone commented Nov 4, 2024

DESCRIBE YOUR PR

See the unchecked rows of https://docs.google.com/spreadsheets/d/1_V8fwvomASiJgXSD4LusD9JrOLZjIG_iCUnvXK3eF2o/edit?usp=sharing for the request.

To verify:
visit: https://sentry-docs-git-more-canonicals.sentry.dev/platforms/javascript/guides/cordova/data-management/sensitive-data/

Inspect and you will see that the canonical tag points to: https://docs.sentry.io/platforms/javascript/guides/koa/data-management/sensitive-data/ as referenced in the spreadsheet.

All five of these link will follow the same behavior.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:35am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:35am

Copy link

codecov bot commented Nov 4, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Apparently there is a 404 introduced with this pr which I find weird since you did not change any links – could you still have a look? There is a github action pointing you to the correct page in this pr

@a-hariti
Copy link
Collaborator

a-hariti commented Nov 5, 2024

I faced the same on another PR @charliemday

probably a bug, but I didn't get why it's happening as the url works when I click on it locally 🤔

@coolguyzone
Copy link
Collaborator Author

LGTM!

Apparently there is a 404 introduced with this pr which I find weird since you did not change any links – could you still have a look? There is a github action pointing you to the correct page in this pr

This one's a bit of a mystery to me, all I did here was update some frontMatter data on a few markdown files, I double-checked the syntax, I'm not sure why it would be throwing a 404 on /api/auth/

@chargome
Copy link
Member

chargome commented Nov 6, 2024

@coolguyzone this was fixed in #11742, just rebase your pr on master

@coolguyzone
Copy link
Collaborator Author

Ah, thanks @chargome

@coolguyzone coolguyzone merged commit a3f8187 into master Nov 7, 2024
11 checks passed
@coolguyzone coolguyzone deleted the more-canonicals branch November 7, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants