feat(dynamic-sampling): organization settings #11791
Draft
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 108 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
lizokm
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks so much for starting on this! I know it's still in draft. Let me know when you'd like me to take another look. Also, take a look at our current DS docs to see if there's anything we can copy over. (https://docs.sentry.io/product/performance/retention-priorities/)
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
jan-auer
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Some ideas for information that could be added:
- In the introduction, explain what "dynamic sampling" truly is. As in, what about it is dynamic and what it tries to achieve.
- How does DS fit with sampling in the SDKs and when do I use which?
- What is the default (100% = no sampling)
- How does DS re-compute rates? Note that here we shouldn't give any strict guarantees (e.g. "every 10 minutes") but mention that there's a short sliding window so that DS can adjust to seasonality like on weekends and over night traffic patterns.
- AM2 and AM3 have different capabilities. The sample rates are chosen automatically on AM2, while only on AM3 do you have the new settings screen and control over rates. We should make this clear. @lizokm, how do we usually talk about the plan generations?
- I'd structure this document into multiple larger blocks (not necessarily sections):
- Organization-wide settings, including the sampling mode, project preview, sample rates
- Project-wide settings, which for now are just the priorities
- Connection to other product surface, esp subscription settings and stats
- We can expand the description of the modes, particularly
- How does DS work in each of the modes (i.e. what's the same and what's different)
- How do I think about configuring each of the modes?
- Especially in manual mode, describe the org-level assist. That's where we could use an arcade.
- What happens when I change into this mode?
- On project preview, what do the estimated rates mean, what's the difference between the two time frames, and how do they relate to what DS actually does?
- Retention priorities are now called "[Dynamic] Sampling Priorities", so let's rename them here, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section under organization settings to explain the benefits of dynamic sampling and its relevant settings
Closes https://github.com/getsentry/projects/issues/214